Commits
Akinobu Mita authored and Pavel Emelianov committed 5dba9c392bd
[PATCH] synclink_gt: fix init error handling Initialization synclink_gt forgot to unregister pci driver on error path. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Cc: Paul Fulghum <paulkf@microgate.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org> [this leads to oopses later on subsequent pci_register_driver() typical oops --adobriyan kernel BUG at lib/list_debug.c:31! invalid opcode: 0000 [#1] SMP last sysfs file: Modules linked in: wdt_pci(U) [maany] CPU: 0, VCPU: 0.1 EIP: 0060:[<c04db3d6>] Tainted: P VLI EFLAGS: 00010246 (2.6.18-rhel5-028stab045-1 #4) EIP is at __list_add+0x3c/0x58 eax: 00000048 ebx: c06db414 ecx: f55e1e78 edx: c063a24f esi: f9bad760 edi: f9c21140 ebp: f9c21300 esp: f55e1e74 ds: 007b es: 007b ss: 0068 Process modprobe (pid: 11261, veid: 0, ti=f55e0000 task=f781ccd0 task.ti=f55e0000) Stack: c063a24f c06db414 21595808 f9c21124 ffffffea c06db3a0 c04d723f fffffffe c06db420 f9c21124 ffffffea c06db3a0 f9c21300 c04d73f0 f9c21124 f9c2110c c053ece0 00000000 c06cf64c f9c210e0 f601ec04 f601e800 f9c21300 c04e2016 Call Trace: [<c04d723f>] kobject_add+0xa2/0x16d [<c04d73f0>] kobject_register+0x19/0x30 [<c053ece0>] bus_add_driver+0x4a/0xfd [<c04e2016>] __pci_register_driver+0x47/0x63 [<c04439be>] sys_init_module+0x176a/0x18ed [<c060b5fa>] do_page_fault+0x320/0x5ad [<c060c4b7>] syscall_call+0x7/0xb ======================= Code: 52 68 12 a2 63 c0 e8 14 67 f4 ff 0f 0b 66 b8 1a 00 b8 c4 a1 63 c0 83 c4 0c 8b 06 39 d8 74 1a 50 53 68 4f a2 63 c0 e8 f4 66 f4 ff <0f> 0b 66 b8 1f 00 b8 c4 a1 63 c0 83 c4 0c 89 7b 04 89 1f 89 77 EIP: [<c04db3d6>] __list_add+0x3c/0x58 SS:ESP 0068:f55e1e74