Fix GPT partition alignment on ploop initNot aligned GPT partition created on 'ploop init'.
Incorrect 'end' parameter passed to parted, it should be 'size-1'.
Reference: PSBM-25910
Reference: ploop@992231
Fix alignment on GPT partition resizeResize creates GPT partition not alligned to cluster blocksize.
Align end of partition to blocksize (use 1 MB if not specified).
Reference: PSBM-25910
Reference: ploop@992198
Fix uuid strings size, use defineI was not able to figure out why any char uuid[] declaration
use size of 61, while it should be 39.
Define UUID_SIZE as 39 and use it whenever needed.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
get_partition_device_name(): fix chmod argumentAs we are creating /dev/ploopNNNp1 device, we probably
want to chmod() it but not /dev/ploopNNN which already exists.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
get_partition_device_name(): don't ignore chmod() errorchmod() should not fail at all here, but if it is, that means
something really bad is happening, so we should tell about it
earlier rather than fail some time later.
This reverts part of commit 0be611c (aka r975730),
restoring back a part of commit 532c80d (aka r943725).
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
make_fs(): fix out of bounds writeThis is a fix to commit ec2c767 (aka r990063).
Reported by Coverity, CID 1195049
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
ploop_create_temporary_snapshot(): fix NULL derefChecking for param == NULL after dereferencing it doesn't make sense.
Same for assigning the parameters and then checking if those are NULL.
Move initialization later in the code, closer to the place where these
are used.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
make_fs(): add -i to mkfsRecent vzctl commit ef320d3 (aka r987982, see also PSBM-19156) introduced
a way to calculate disk space required depending on the number of inodes
specified by vzctl {create|set} --diskinodes option. Internally it
relies on the fact that mkfs creates 1 inode per 16K disk space,
but the value might be changed in /etc/mke2fs.conf. Therefore,
let's specify it here explicitly to not screw up above ...
ploop_check: fix for ro fs caseThere is nothing wrong in having non-top-level images on a read only
file system. Unfortunately, since commit f5e47191 this is no longer
possible:
Error in ploop_check (check.c:224): ploop_check: can't open
/media/ephemeral0/vz/private/3221/root.hdd/root.hdd:
Read-only file system
So, ploop mount doesn't work at all.
To fix, let's check if an image is on read-only filesystem, and do
a rea...
parse_uuid: add {} if necessaryWhen working with ploop from a command line, one usually copy-pastes
(rather than types) UUIDs. The problem is, when selecting a UUID
in a terminal by double clicking on it, curly brackets are not selected,
so one either have to add those manually, or select UUID using click
and drag which is way slower and more error-prone, leading to
frustration, lower serotonine levels, and in rare cases eve...
tools: use parse_guid() everywhereIn this case, we will error out much earlier, and it some cases
the error message is way more clear (for example,
not "Can't find UUID" but "Invalid UUID").
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
ploop check dd.xml: fix by using check_deltas()Recently ploop check form with DiskDescriptor.xml was introduced.
Its implementation copied some code from check_deltas() which is
now evolving separately. Another problem is ploop check was checking
all deltas, whether they were used in a current configuration or not.
Fix both issues by switching to check_deltas().
One side effect is we are losing an ability to set various flags.
This is pro...
check_deltas: open delta rw to perform auto fixingNon top delta could be in inconsistent state and require fixing,
so open all delta 'rw' on ploop mount action
Reference: PSBM-25252
Reference: ploop@986717
Reviewed-by: mpatlasov@parallels.com
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
e2fsck: return fsck exit code to callerAdded fsck_rc member to 'struct ploop_mount_param'.
It will allow for the caller to analyze fsck exit code.
Reference: PSBM-25464
Reference: ploop@986561
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Add ploop_is_mounted()Add a way to get ploop status without lock, to avoid lock waiting
in case way too long running operation is in progress.
[kir@openvz.org: dynload.h patching]
Reference: ploop@985158
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
ploop_create_temporary_snapshot(): fix messageLog message is a sentence, it should start with Uppercased letter.
Reference: ploop@983788
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
check_snapshot_mount(): simplify error path1. Assign ret at declaration
2. Do ploop_free_array() in one place
3. No need to check ret for non-zero
Reference: ploop@983787
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
check_snapshot_mount(): fix typosFix typos in comments and an error message added in commit
ploop@983110 aka fd00205
Reference: ploop@983786
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
ploop_merge_snapshot_by_guid: deny snapshot deleting if mountedPloop images could be mounted many times by using component_name,
this introduce to us two resrictions on snapshot delete:
1) if snapshot is mounted it can not be deleted as far as it used
2) If upper(child) snapshot is mounted the snapshot can not be deleted
as far as image which will be eleted is used
So jut display errror message that snapshot cannot be merged
Reference: ploop@983110
Use component name in find device logic only on mount/umountAll ploop action performed on main ploop device (without component_name).
The only mount/umount use component_name to mount/umount snapshots.
Reference: ploop@983108
Introduce two locking schemas for temporary snapshotsTemporary snapshot locked in
ploop_create_temporary_snapshot(..., int *holder_fd)
the snapshot is locked until caller not closed holder_fd
It is hard to use that schema in bash script. This patch introduces
lock by ploop device, in case holder_fd is not passed the snapshot
is in locked state until device is mounted.
Reference: ploop@982200
ploop tsnapshot: allow to specify mount point #ploop tsnapshot -u <uuid> -c <component_name> [-m MOUNT_POINT] DiskDescriptor.xml
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@981721
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
is_snapshot_in_use: use open_count to check locking stateThe temporary snapshot do open /dev/ploopN to lock the snapshot.
This patch introduces logic to handle /sys/block/ploopN/pstate/open_count
reference counter on auto merge,
Snapshot is locked if:
count >= 2
count == 1 and not mounted
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@981711
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
validate_disk_descriptor: validate top delta (9/10)Top delta can't be a temporary snapshot
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979416
ploop_switch_snapshot: deny to switch to temporary snapshot (8/10)Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979414
auto merge temporary snnapshot on mount & snapshot-create action (7/10)Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979413
merge temporary snapshot (6/10)Added functionality to merge all not in use temporary snapshots
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979412
ploop_merge_snapshot_by_guid: umount snapshots on merge (5/10)To not fail merging temporary snapshot, do umount all snapshots
that were mounted by guid.
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979410
ploop_get_dev_by_delta: search device by basedelta & topdelta pair (4/10)Will be used to release mounted snapshot on snapshot merge action.
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference: ploop@979404
ploop_find_dev, ploop_get_dev_by_delta: fix argsFor some reason, the first two arguments of these two functions were
mixed up. It all worked though, because of double error effect.
This also presumably makes ploop_get_devs() working (currently there
are no users of this function).
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Create temporary snapshot (3/10)Temporary snapshot marked as <Temporary> in DiskDescriptor.xml
after snapshot have created it mounted and snapshot device is opened
to lock snapshot from auto merge. The caller should close holder_fd
and merge snapshot.
* API
struct ploop_tsnapshot_param {
char *guid;
char *target;
char device[64];
};
int ploop_create_temporary_snapshot(struct ploop_disk_images_data *di,...
Prepare ploop_create_snapshot to process temporary flag (2/10)* make ploop_create_snapshot() as wrapper on do_create_snapshot()
* move ploop_create_snapshot to lib/snapshot.c
Reference: ploop@979395
Add temporary snapshot flag to DiskDescriptor.xml (1/10)Add ability to read/write <Temporary> xml tag
Reference: PSBM-24755 "Temporary snapshots & their auto merge"
Reference:ploop@979393
Kir Kolyshkin