list.h: remove no-longer needed type castsDue to previous commit 4b079d2b7ee2f8398ff67e2c40b62c50ccf06e12
it is no longer needed to type-cast list_head_t* to list_elem_t*,
thus cleaning it up.
Remove compiler warnings by fixing list_elem_t and list_head_t definitionsThere were a few warnings like this:
config.c: In function 'store_dev':
config.c:1078: warning: dereferencing type-punned pointer will break strict-aliasing rules
The problem is caused by the fact that two different types -- list_head_t
and list_elem_t -- are defined in list.h and used for double linked list
routines. In fact, those types are the same, but since they are defined
separately,...
Relocate cron master file from pkgdatadir to pkgconfdir.Configuration files should not be placed in datadir.
[kir@openvz.org: fixed commit message]
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Kir Kolyshkin <kir@openvz.org>
Fix vzctl destroy logic.vzctl destroy operation is asyncronous: it moves VE private area to a temp
directory on the same filesystem, and then forks rm -rf in background.
The problem: that background task removes everything that is sitting
under the 'tmp' directory under the filesystem root where VE private
area is situated (usually /vz/tmp or /var/lib/vz/tmp).
Rework the removal logic to remove only those temporary...
bash-completion: fixed support for VE names with dashesCommit 7dd83295d36d5d83e98f5bc5bc0cfdbfa2c05141 introduced support
for VE names in bash_completion script. Unfortunately it stripped
all the dashes ("-") from VE names, so it was not possible to use
it with names such as deb-build-amd64.
This patch fixes it.
init.d/vz-redhat: removed unused codeFunction check_is_root() is not used, thus removing it.
Noticed by Thorsten Schifferdecker, see
http://bugzilla.openvz.org/show_bug.cgi?id=473
init.d/vz-redhat: really honour MODULES_DISABLED=yesBUG: when MODULES_DISABLED="yes" set in /etc/vz/vz.conf and a non-modular kernel is
used; non-OpenVZ modules are still loaded, like af_packet and the related
iptables_modules.
This patch fixes it.
src/lib/config.c: Fix "cast discards qualifiers from pointer target type" warningssrc/lib/config.c (vps_parse_opt): Remove const qualifier from
"const char *val" argument, because it may be passed to parsers
which in turn may modify it using strtok(3).
src/lib/config.c (parse_setmode, conf_store_str, parse_meminfo,
parse_ub): Add const qualifier to "char *val" argument.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Kir Kolyshkin <kir@openvz.org>
Change the default behaviour for AC_PROG_LIBTOOL to disable build of static libraries. The user may still override this default by specifying --enable-static.Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Kir Kolyshkin <kir@openvz.org>
Move cronjob installation/removal logic to initscriptIf OpenVZ is not started, it doesn't make sense to execute its
cron jobs every five minutes. This fills up system logs, reduces
notebook battery life etc. Moving cronjobs management to initscript
fixes that.
Idea stolen from mailman initscript.
init.d/vz-redhat: display error if there's oneIn some cases vz script get a fatal error from modprobe. By not displaying
the error we left user to guess what's wrong. This patch fixes that.
"Idea" stolen from Red Hat netdump package initscript.
Simplified vzctl cron.d entries.It makes little sense to have two separate files in /etc/cron.d/, so
merge both vpsnetclean and vpsreboot into a sinlge file with a simple name.
Also removed licensing blurb since it doesn't make much sense here.
src/lib/vps_configure.c: get rid of a warningRemove the following warning:
vps_configure.c: In function ‘vps_ip_configure’:
vps_configure.c:274: warning: cast discards qualifiers from pointer target type
src/vzlist.c (*_sort_fn, *_search_fn): Add const qualifier to casts from const pointer type[kir@openvz.org: limited line width to <80 chars]
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Fix ndsend compile with Gentoo linux-headers-2.6.19.2-r2The problem is abovementioned linux-headers change linux/if.h file in a way
that it does no more include linux/types.h, thus unknown types like __u8 etc.
We add this include explicitly and fix the problem.
Implement MODULES_DISABLED in gentoo initscript; document it.This is an addition to commit 37861579f02fee2f6a8aea48282586b0a45d94bc
In case MODULES_DISABLED is set to "yes" in global config,
no attempt is made to load/unload OpenVZ kernel modules
in vz initscripts.
http://bugzilla.openvz.org/132
configure: skip useless/harmful C++/F77 checks by libtoolAC_PROG_LIBTOOL configure macro wants to run a lot of C++ and Fortran checks
Since vzctl does not use any C++ or Fortran code, those checks are useless.
But this is not a problem -- the problem is in case of there is no C++
compiler, configure fails miserably with the following diagnostics:
checking how to run the C++ preprocessor... /lib/cpp
configure: error: C++ preprocessor "/lib/cpp" ...
Really fix installation of proper VE configs.An addition to the previous commit 82968bc396108a54c22d2e32b3a69afb57498526.
The problem apparently is when variable assignment is performed in Makefile,
and the line (like A = b) is preceded with a TAB character, GNU make
just ignores this line. No error, no warning, just ignore...
Install proper (arch-dependent) VE configsPrevious implementation was flawed and didn't really worked,
as discovered by Thorsten (bug #419). Redone with obligatory
arch-suffixes and temporary files.
http://bugzilla.openvz.org/419
Do not install directory if a corresponding feature is not enabled.Problem: even if, say, bash_completion feature is not enabled via configure,
a corresponding directory (bash_completion.d) is installed anyway. Same problem
with cron, logrotate, udev.
Apparently it's not enough to guard "bashc_DATA" in Makefile
by "if ENABLE_BASHCOMP" -- it is also required to guard the directory.
Fix to make configure working in builddir != srcdir.Apparently automake is smart enough to add $(srcdir) by itself.
Without this patch, make tried to refer to ../../bin/../../bin/ files
which is shows that srcdir has been added twice -- by us and by automake.
vzmigrate: add --delete to rsync callsDuring testing and debugging of a problem on Debian systems
(which I later found out was corrected in 3.0.13 version) I found
that the rsync commands in vzmigrate can give quite unexpected
results.
The command looks basically like this:
rsync -aH ${from} ${to}
This means that files are copied from ${from} to ${to}, but if
files already exist on ${to} from some older copy the old files
that do...
Speedup 'vz stop' action * removed 'sleep 1' * added parallel value auto calculation by the rule: num_cpu * 4http://bugzilla.openvz.org/show_bug.cgi?id=431
Kir Kolyshkin
Igor Sukhih
