src/quotaon.c: fix compilation with clangFix the following error:
quotaon.c:1005:7: error: variable 'ugid' is used uninitialized whenever
'||'
condition is true [-Werror,-Wsometimes-uninitialized]
if (argc != 5
^~~~~~~~~
quotaon.c:1017:17: note: uninitialized use occurs here
quota_setugid(ugid, &stat, NULL);
^~~~
quotaon.c:1005:7: note: remove the...
quotacheck.c: fix POWER compileFix the following error while compiling for POWER:
> quotacheck.c: In function ‘scan’:
> quotacheck.c:260:2: error: format ‘%lld’ expects argument of type ‘long long int’, but argument 5 has type ‘qint’ [-Werror=format=]
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
quota_io.c: fix power compilationFix a couple of printf format errors:
> quota_io.c: In function ‘chksum_quota_file’:
> quota_io.c:1394:2: error: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 3 has type ‘chksum_t’ [-Werror=format=]
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Mark error() and debug_print() as format(printf)1 Add attribute(format(printf)) to error() and debug_print() function
so that compiler knows that these functions expect printf-style
arguments.
2 Fix the errors discovered by the above change.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Fix POWER compilationOn POWER, __u64 type is "unsigned long", while on x86_64 it
is defined as "unsigned long long". To work around this discrepancy,
we need to typecast some printf arguments.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
[build] fix mandir installationWhen building and installing (build for Debian package at least) it
creates a directory /man8 that should not exist. The reason for this
is that src/Makefile use MANDIR while this directory is set in
man/Makefile.
At the same time man/Makefile have problem to create the man8 directory,
because INSTALL is not defined.
Fix both.
[kir@openvz.org: remove MANDIR= from make install line in .spec]
...
Released vzquota 3.1Changes
=======
See http://wiki.openvz.org/Download/vzquota/3.1/changes
Thanks
======
OpenVZ project would like to thank the following people who contributed patches
and/or provided bug reports for this release:
* Dmitry V. Levin
* Peter Volkov
* Peter Linnell
* Maxim Shchelokov
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
src/quotacheck.c: fix compilation on old platformsWe only need linux/magic.h for a single define which we already have defined.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Makefile: remove --exclude-vcs from tar optionsOlder tar does not understand it. Use --exclude .git instead
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
vzquota(8): -s, --sub-quotas is in fact accepted by setlimithttp://bugzilla.openvz.org/2310
Reported-by: Maxim Shchelokov <maks3004@inbox.ru>
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
man: add missing macros (.SY/.OP/.YS and .EX/.EE)Apparently, even RHEL6 uses very old groff version (1.18) in which
all the above macros are not available, leading to ugly rendering.
We want those macros since they make the pages look better, so to avoid
the above ugliness we can just add the macros into each and every man page.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Makefile: better tar targetModern tar complains that directory is being changed as we read it.
Fix it by making tar in .. dir and then moving it here.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Improve quotactl_syscall()Do proper chroot() and return back, checking for errors on every stage.
Based on a patch by Andrey Mirkin.
Reference: vzquota@118755
src/syscall.c: fix using GNU old-style structure field designatorThe following warning given when trying to use clang:
syscall.c:41:6: error: use of GNU old-style field designator extension [-Werror,-Wgnu-designator]
cmd : _cmd,
^~~~~~~~~~~~~
.cmd =
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
vzdqdump, vzdqload: add -F to dump/load first level quotasNeeded for migration to a different arch (32 <-> 64) over shared storage.
Reference: PCLIN-27498
Reference: vzquota@592370
vzdqdump(8): fix -G -U -T in SYNOPSYSEarlier commit 956433f made options -G, -U, -T exclusive.
In fact, they can be used together.
Fix it.
The only thing I don't know how to achieve is marking it in synopsys
that at least one of these options should be used.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Fix error message when native quota is running on /vzMessage was incorrectly saying "another quota check is running"
(it has nothing to do with quota check). Change that to
"Native quota is running". New text message is provided by vlikhanov@.
Reference: PCLIN-27571
Reference: vzquota@603951
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Remove jquota filesjquota was an experimental feature never merged to this vzquota,
except for these files accidentally added by commit 278afb0e.
Remove those.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Make ext4 delalloc work with vzquota (rhel6 only)Many applications access private area beyond vzquota, after this many inodes
probably will have delayed blocks. For example:
tar zxf ve-private-area.tar.vz -C /vzt/private/$VEID
Later application must call quota recalc in order to update quota numbers:
vzquota init $VEID ......
But delayed blocks allocation happened, so quota is inconsistent,
and inodes still contain delayed blocks which...
Fixed compilation warningquotacheck.c:252: error: ignoring return value of 'fchdir', declared with attribute warn_unused_result
Reference: vzquota@737078
man/vzquota.8: better subsectioning(1) Get rid of sub-sub-sections faked using .TP, make only these ones:
General
Quota Commands
Setting quota limits
Other options
This might not be the best but it's much better than before
(2) Add vertical space before/after .SS
man/*: use EXIT STATUS not DIAGNOSTICSDIAGNOSTICS is for various error messages printed by a program etc.
The proper name is EXIT STATUS, use it.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
man/*: fixes(1) Do not highlight program name in NAME
(2) Beautified SYNOPSYS using .SY/.OP/.YS
(3) vzdqcheck: expanded DESCRIPTION
(4) Simplified formatting in OPTIONS
(5) Added SEE ALSO
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
inline functions must me static if using -std=gnu99Fixes the following compilation error:
cc -pipe -I../include -std=gnu99 -g -Wall -Werror -Wformat -D_FILE_OFFSET_BITS=64 -D_LINUX_QUOTA_VERSION=6 -D_LARGEFILE64_SOURCE -DVARDIR=\"/var\" -o vzquota common.o quota_io.o syscall.o main.o stat.o quotaon.o quotacheck.o
quota_io.o: In function `lookup_dquot_':
/home/kir/git/vzquota/src/quota_io.c:67: undefined reference to `hash_dquot'
quota_io.o: ...
Fix playing with __USE_ISOC99, use -std=gnuc99 insteadhttp://bugzilla.openvz.org/1664
Reported-by: peter.linnell@inria.fr
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
quota on: more info on failed quota on with EEXISTIt is impossible to have both native (i.e. uid/gid) Linux quota on
and vzquota. So, if native quota is enabled on /vz, vzquota can't
be turned on. Explain it in error message, making it a bit more
descriptive.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Fix exit code in case quota file does not existsIn one place we were returning EC_QUOTAFILE
(4 -- Quota file error) while it should be
EC_NOQUOTAFILE (11 -- Quota file does not exist).
Fix it.
Signed-off-by: Kir Kolyshkin <kir@openvz.org>
Alexander
